feat: Bot warning when mentioning users not in a channel #30464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 486954a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #30464 +/- ##
============================================
- Coverage 77.40% 49.27% -28.13%
============================================
Files 277 3297 +3020
Lines 8731 80908 +72177
Branches 1620 16508 +14888
============================================
+ Hits 6758 39869 +33111
- Misses 1565 36380 +34815
- Partials 408 4659 +4251
Flags with carried forward coverage won't be shown. Click here to find out more. |
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: chore: move Omnichannel toolbox section from sidebar room list (#30502) fix: RTL lang crashes Moderation Console (#30393) feat: New records page analytics tab (#30373) chore: Changing some key translations - Setup Wizard (#30462) feat: use isolated-vm to run integration scripts (#30229) fix: do not broadcast events from the local node to the local service (duplicated event) (#30446) fix: Microsoft autotranslate not working (#30390) chore: `ResetPasswordPage` a11y improvements (#30479) chore: `ResetPasswordForm` a11y improvements (#30476) chore: Move bad words filter callback to service (#30241) fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452) chore: add tooltip to mentions (#30445)
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits) fix: don't save the filter value on offlineMessageChannelName (#30576) feat: New permission to kick users (#30535) chore: improve message link focus (#30578) chore: Add required visual indication on `EditRoom` name input (#30589) fix: user dropdown menu position on RTL layout (#30490) chore: add missing `_id` field to `AtLeast` (#30592) test: Improve tests for legacy omnichannel analytics (#30379) fix: Remove monitors query restrictions on update (#30550) chore: license v3 invalidation (#30585) chore: `CreateDirectMessage` a11y form improvements (#30581) chore: `CreateDiscussion` a11y improvements (#30583) chore: License v3 - behavior and limited reached triggers (#30561) chore: Improve `groups.create` endpoint for large amounts of members (#30499) feat: Monitors able to forward chats without joining (#30549) feat: Deployment Fingerprint (#30411) chore: fix flaky agents & custom fields tables tests (#30580) feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) ...
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Auto-translate doesn't work on E2E rooms (#30369) test: Validate monitors data access (#30593) fix: reset file input after uploading file (#30529) refactor: AutoCompleteTagsMultiple to TS (#30577) fix: DM room stay "read only" after the deactivate and reactivate user with "guest" role (#30459) fix: Change plan name from Enterprise to Premium on marketplace filtering (#30616) regression: test license from cloud (#30609) fix: Unable to send attachments via email as an omni-agent (#30525) ci: fix lint task fix: cloud alerts (#30607) feat: License trigger cloud sync after reach limits (#30603) chore: Change plan name Enterprise to Premium on marketplace (#30487) chore: Improve cache of static files (#30290) regression: Undefined MAC count on startup cloud sync (#30605) chore: Change Records page name to Reports (#30513)
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: feat: add tooltip to badge mentions (#30590) chore: improve `Tag` a11y link (#30636) refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634) fix: Improve FileProxy Handling, set Content-Type (#30427) refactor: `EditRoomInfo` to typescript (#28318) fix: mobile ringing notification missing call id (#30614) fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560) test: More tests for groups kick (#30536) fix: Threads breaking after sending messages too fast (#30622) chore: Remove text decoration from room tag (#30606) i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613) fix: File attachments have no content when exporting room messages as file (#30596) fix: use setImmediate to handle username update (#30500) chore: `AnalyticsReports` visual adequacy (#30617)
dionisio-bot
bot
added
stat: ready to merge
yash-rajpal
approved these changes
Nov 22, 2023
dionisio-bot
bot
added
stat: ready to merge
MarcosSpessatto
approved these changes
Dec 4, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
scuciatto
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
TC-948
Steps to test or reproduce
Further comments